Fix plot_histogram distribution detection with leading int zeros #15497
+64
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a probability distribution dictionary has integer zeros before
float values (e.g., {0: 0, 1: 0, 2: 0.5, 3: 0.5}), plot_histogram
incorrectly detected it as "counts" mode because it only checked the
type of the first value.
Changed the detection logic to check if any value is a float, rather
than only the first value. This fixes cases where distributions with
leading/trailing integer zeros were coerced to integers, resulting in
empty or incorrect plots.
Fixes Qiskit#11949
qiskit-bot
added
the
Community PR
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11949
When a probability distribution dictionary has integer zeros before float values (e.g.,
{0: 0, 1: 0, 2: 0.5, 3: 0.5}),plot_histogramincorrectly detected it as "counts" mode because it only checked the type of the first value. This caused float probabilities to be coerced to integers, resulting in empty or incorrect plots.Changed the detection logic to check if any value is a float, rather than only the first value. This is the approach suggested by @jakelishman in the issue comments.
Changes
plot_histogram()_is_deprecated_data_format()(which the previous PR Fix to #11949: plot_histogram fails to operate correctly when numerous starting and ending values are zero #11979 missed)Test plan
test_plot_histogram.pytests passNote: This is a fresh implementation of the fix from stale PR #11979, with the additional fix for
_is_deprecated_data_format(), tests, and release note that were requested but never added.