-
Notifications
You must be signed in to change notification settings - Fork 195
Allow some custom return types to be annotated as generic classes at runtime #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IvanIsCoding
wants to merge
11
commits into
Qiskit:main
Choose a base branch
from
IvanIsCoding:pep563-custom-return-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a3c0636
Allow PyGraph and PyDiGraph to be annotated as generic classes at run…
IvanIsCoding 350f60c
Black
IvanIsCoding 39402e1
Add release notes
IvanIsCoding 06ec02b
Add __class_getitem__ to stubs
IvanIsCoding b2d5dad
Allow some custom return types to be annotated as generic classes at …
IvanIsCoding 81a3d6c
Fix test with same name
IvanIsCoding 5c948bd
Merge branch 'main' into pep563-custom-return-types
IvanIsCoding 7a64ffe
Merge branch 'main' into pep563-custom-return-types
IvanIsCoding 9d9e5ef
Black
IvanIsCoding 9fe42a6
Merge remote-tracking branch 'upstream/main' into pep563-custom-retur…
IvanIsCoding 7ed3958
Merge branch 'main' into pep563-custom-return-types
IvanIsCoding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of all changes this is the one I am least confident about because it feels like a hack