-
Notifications
You must be signed in to change notification settings - Fork 195
Remove Python 3.9 support and the legacy retworkx import
#1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 19056599075Details
💛 - Coveralls |
|
I bumped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this, I know we had previously discussed stopping retworkx releases in 1.0, but I think it's been long enough. Just a few inline questions. The only open question really is if we want to add 3.14 to the package metadata and test matrix in this PR or do it separately.
|
I will address the comments on Saturday. I plan to add 3.14 support on a separate PR. It will need some minor change for the MyPy stub tests. Right now, we are using a version that is pinned and might not support 3.14. At least I am confident there are no pre-compiled binaries for it (although MyPy ships a Python-only version) |
a4897a7 to
f52487b
Compare
|
Also, I just remembered we need to bump cibuildwheel’s version to support testing with 3.14. So after we merge this (it’s ready), I will kick off the 3.14 support PR separately and its test builds |
In short, this PR:
retworkxshim