Migrate from setuptools-rust to maturin#1527
Open
IvanIsCoding wants to merge 62 commits intoQiskit:mainfrom
Open
Migrate from setuptools-rust to maturin#1527IvanIsCoding wants to merge 62 commits intoQiskit:mainfrom
setuptools-rust to maturin#1527IvanIsCoding wants to merge 62 commits intoQiskit:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21565465095Details
💛 - Coveralls |
Open
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #1523, for the true diff see IvanIsCoding/rustworkx@ruff-format...IvanIsCoding:rustworkx:free-threaded-314
This is a step towards #1251. Although not strictly required,
maturinjust has a nicer integration with ABI 3 and free-threaded builds.Currently, the main blocker for free-threaded support is that we declare we use ABI 3 in
pyproject.toml. That fails for free-threaded builds. Maturin on the other hand is programmed to ignored ABI 3 in free-threaded builds because it knows there's no ABI for it yet.3.14t inclusion to CI will come in a separate PR.