Skip to content

fix undefined should be returned when no keyword matches#127

Open
pete-mcwilliams wants to merge 2 commits intoQix-:masterfrom
pete-mcwilliams:master
Open

fix undefined should be returned when no keyword matches#127
pete-mcwilliams wants to merge 2 commits intoQix-:masterfrom
pete-mcwilliams:master

Conversation

@pete-mcwilliams
Copy link
Copy Markdown
Contributor

@LitoMore
Copy link
Copy Markdown
Collaborator

I feel this is a bit over-patched.

Maybe we should only pin the color-name at 2.0.0 to fix the original issue.

What do you think @Qix-?

Copy link
Copy Markdown
Owner

@Qix- Qix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LitoMore I think it's fine; not sure how color-name will change in the future. This is defensive and low-barrier enough. Just don't want to do two lookups, hence the request for the change.

Co-authored-by: Josh Junon <Qix-@users.noreply.github.com>
@pete-mcwilliams pete-mcwilliams requested a review from Qix- December 4, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants