Fix MULTI_PAYMENT balance check (NO_BALANCE validation)#306
Open
QuickMythril wants to merge 1 commit intoQortal:masterfrom
Open
Fix MULTI_PAYMENT balance check (NO_BALANCE validation)#306QuickMythril wants to merge 1 commit intoQortal:masterfrom
QuickMythril wants to merge 1 commit intoQortal:masterfrom
Conversation
The MULTI_PAYMENT validator currently returns NO_BALANCE when the sender’s confirmed QORT balance is greater than the fee. That comparison is reversed and causes all MULTI_PAYMENT transactions to be rejected even when the sender has sufficient funds. This PR flips the check to ensure NO_BALANCE is only raised when balance is less than the required fee. This restores expected validation behavior and allows MULTI_PAYMENT transactions to pass when the sender can cover the fee and payment amounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MULTI_PAYMENT validator currently returns NO_BALANCE when the sender’s confirmed QORT balance is greater than the fee. That comparison is reversed and causes all MULTI_PAYMENT transactions to be rejected even when the sender has sufficient funds.
This PR flips the check to ensure NO_BALANCE is only raised when balance is less than the required fee. This restores expected validation behavior and allows MULTI_PAYMENT transactions to pass when the sender can cover the fee and payment amounts.