Fix #316: add Linux-native tray fallback and notifications when AWT SystemTray is unavailable#317
Open
QuickMythril wants to merge 3 commits intoQortal:masterfrom
Open
Fix #316: add Linux-native tray fallback and notifications when AWT SystemTray is unavailable#317QuickMythril wants to merge 3 commits intoQortal:masterfrom
QuickMythril wants to merge 3 commits intoQortal:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #316 by making Qortal Core tray support work on Linux systems where
java.awt.SystemTrayis unsupported.Root Cause
The existing tray implementation was AWT-only.
On many Linux desktop setups,
SystemTray.isSupported()returnsfalse, so tray initialization exited early and no icon/menu/notifications were available.What This PR Changes
1) Add Linux-native tray backend fallback
com.dorkbox:SystemTraydependency inpom.xml.SysTraynow supports backend selection via:-Dqortal.tray.backend=auto|awt|sni|appindicator|noneautobehavior:2) Improve backend diagnostics
3) AppIndicator tooltip fallback
setStatus) instead of tooltip only.4) Linux notification support
notify-sendfromshowMessage(...).notify-sendis unavailable/fails, it gracefully falls back to debug logging (no crash/regression).Compatibility / Risk
autofallback is needed.Commits Included
65fb8cfdfeat(gui): add Linux-native system tray backend fallback3cfc1254fix(gui): fallback to status text for AppIndicator tray139a3798feat(gui): send Linux tray notifications via notify-sendValidation
mvn -DskipTests compile).appindicator: