RMQ #12
Open
RMQ #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-of-kpp
reviewed
May 17, 2019
code-of-kpp
left a comment
code-of-kpp
left a comment
There was a problem hiding this comment.
Please add RMQ use cases to README.md
pysdsl/test/test_rmq.py
Outdated
| from pysdsl import rmq_sada, rmq_sct, rmq_sparse_tables | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
please, use pylint to check python code quality and black to format it.
pysdsl/test/test_rmq.py
Outdated
|
|
||
|
|
||
| def test_rmq_sada(): | ||
| _test_rmq(rmq_sada['Min'], IntVector, min) |
There was a problem hiding this comment.
that can be parametrized, just provide a list of tuples to pytest.mark.parametrized. You also may want to have names argument in parametrized
| // containers names | ||
| namespace RAC_names { | ||
| constexpr char INT_VECTOR_NAME[] = "IntVector", | ||
| INT16_VECTOR_NAME[] = "Int16Vector"; |
There was a problem hiding this comment.
can we inherit them from int_vectors tuple?
dimak24
force-pushed
the
rmq
branch
2 times, most recently
from
66b254f to
8346469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.