cmake: add find_dependency calls to config file#442
Open
iblech wants to merge 1 commit intoQtExcel:masterfrom
Open
cmake: add find_dependency calls to config file#442iblech wants to merge 1 commit intoQtExcel:masterfrom
iblech wants to merge 1 commit intoQtExcel:masterfrom
Conversation
The generated QXlsxQt*Config.cmake was missing find_dependency() calls for Qt components. This causes build failures when consuming projects use find_package(QXlsxQt6) because Qt6::GuiPrivate (declared in INTERFACE_LINK_LIBRARIES) is not found. Add find_dependency() for Core, Gui, and conditionally GuiPrivate (required for Qt 6.10+) following CMake package configuration best practices. Fixes build failures with Qt 6.10+ where GuiPrivate became a separate CMake component (QTBUG-87776).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gpt4all is a tool for locally running LLMs. It vendors (a modified version of an older version of) QXlsx. However, with current Qt, compilation of Gpt4all fails:
Using Claude Opus 4.5, @photm5 and I tracked this problem down to an issue in QXlsx. Unfortunately, we are not experts on Qt build infrastructure and cannot personally judge the appropriateness of this patch. However, we can confirm that Gpt4all builds and works nicely with it. Hence we submit this for your consideration :-) Thank you for your work on QXlsx!
Here is Claude's detailed description: