Exclusive access task by yzcj105 · Pull Request #1025 · QuEraComputing/bloqade-analog

yzcj105 · 2025-04-29T14:03:16Z

Add exclusive access

os.environ['ZAPIER_WEBHOOK_URL'] = "XXXX"
os.environ['ZAPIER_WEBHOOK_KEY'] = "XXXXX"
os.environ['VERCEL_API_URL'] = "XXXXX"
from bloqade.analog.task.exclusive import HTTPHandler, ExclusiveRemoteTask
result = prog.quera.custom().run_async(10, ExclusiveRemoteTask)
result.fetch()
result.report().show()

The environment variables should be set before import ExclusiveRemoteTask.

Test

simple unit test for HTTPHandler and ExclusiveRemoteTask
Integration test with a simple example. Code has been mailed to @weinbe58 and @jon-wurtz .

Waiting time

Once job has been submitted, the status would be "Accepted".
In about 2-10mins, it will show up in the dashboard, the status would become "Enqueued".
It takes some time (a few hours) until job finished. The status would become "Completed".

…ry field

github-actions · 2025-04-29T14:05:44Z

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-01 15:09 UTC

weinbe58

The constructor of the class needs some work to make it not crash the CI if you have any questions lets just set up a pair coding session to fix the issue.

weinbe58 · 2025-04-29T17:25:34Z

src/bloqade/analog/task/base.py

-    @property
-    @abc.abstractmethod
-    def parallel_decoder(self) -> ParallelDecoder: ...
-


This shouldn't be deleted, this is needed to get things working with the Report object.

weinbe58 · 2025-04-29T17:27:13Z

src/bloqade/analog/task/exclusive.py

+
+
+@ExclusiveRemoteTask.set_serializer
+


Suggested change

removing a space here.

weinbe58 · 2025-04-29T17:30:03Z

src/bloqade/analog/task/exclusive.py

+class ExclusiveRemoteTask(CustomRemoteTaskABC):
+    def __init__(
+        self,
+        task_ir: QuEraTaskSpecification,
+        metadata: Dict[str, ParamType],
+        parallel_decoder: ParallelDecoder | None,
+        http_handler: HTTPHandlerABC | None = HTTPHandler(),
+        task_id: str = None,
+        task_result_ir: QuEraTaskResults = None,
+    ):
+        self._http_handler = http_handler 
+        self._task_ir = task_ir
+        self._metadata = metadata
+        self._parallel_decoder = parallel_decoder
+        float_sites = list(
+            map(lambda x: (float(x[0]), float(x[1])), task_ir.lattice.sites)
+        )
+        self._geometry = Geometry(
+            float_sites, task_ir.lattice.filling, parallel_decoder
+        )
+        self._task_id = task_id
+        self._task_result_ir = task_result_ir


As per our discussion 1 on 1, use a dataclass to clean up this implementation, Also you should use default_factories for the default values instead of instances of objects that are mutable.

weinbe58 · 2025-04-29T17:31:01Z

src/bloqade/analog/task/exclusive.py

+        else:
+            self._task_result_ir = QuEraTaskResults(
+                task_status=QuEraTaskStatusCode.Failed)
+        print(self.task_result_ir)


Suggested change

print(self.task_result_ir)

removing debug print statements.

weinbe58 · 2025-04-29T17:33:08Z

Also you should add a test using the Test interface we discussed.

…g in HTTPHandler and ExclusiveRemoteTask

github-actions · 2025-04-30T21:56:24Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
8445	7453	88%	0%	🟢

New Files

File	Coverage	Status
src/bloqade/analog/task/exclusive.py	36%	🟢
TOTAL	36%	🟢

Modified Files

No covered modified files...

updated for commit: 06b090c by action🐍

codecov · 2025-04-30T21:56:43Z

Codecov Report

Attention: Patch coverage is 36.11111% with 115 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/bloqade/analog/task/exclusive.py	36.11%	115 Missing ⚠️

📢 Thoughts on this report? Let us know!

yzcj105 · 2025-04-30T22:17:50Z

Updates:

Use @dataclass for ExclusiveRemoteTask
** clean up the init and use __post_init__ instead
** use field(default_factory=HTTPHandler) to avoid creating new obj in the default arguments of __init__ function, so that during import, no objects are created.
reformatted by black and remove unused imports and duplicated imports.

Test

Tested both case for single job and batch job
Test load( save(results, "result.json")) contains exact same data as the variable results

jon-wurtz · 2025-04-30T23:51:58Z

Looks good to me, my test script runs 👍. @weinbe58 merge at your convenience.

weinbe58 and others added 10 commits April 14, 2025 16:22

Removing uneeded interface

27d0653

WIP:exlcusive access class

b9d5db8

WIP: saving results

b2eb517

exclusive access v1

9b9e20b

remove prints for debug

590c517

fix: status return code

b56194b

status code "Submitted" -> Enqueued

7dcb7af

refactor: enable saving and serialization and ExclusiveRemoteTask

aaa575d

refactor: comment out debug print statement in ExclusiveRemoteTask

a460d23

refactor: streamline task status query logic and remove unused geomet…

74c53fa

…ry field

yzcj105 requested review from jon-wurtz and weinbe58 April 29, 2025 14:03

yzcj105 added the enhancement New feature or request label Apr 29, 2025

weinbe58 requested changes Apr 29, 2025

View reviewed changes

yzcj105 added 2 commits April 30, 2025 17:42

use dataclass for ExclusiveCustomRemoteTask

2927372

refactor: use black to clean up whitespace and improve code formattin…

1870b89

…g in HTTPHandler and ExclusiveRemoteTask

yzcj105 added 2 commits April 30, 2025 18:01

clean up duplicated imports

2f98ecf

fix: add missing newline for improved code readability

06b090c

weinbe58 merged commit fb95cb4 into main May 1, 2025
7 of 8 checks passed

weinbe58 deleted the exclusive-access-task branch May 1, 2025 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Exclusive access task#1025

Exclusive access task#1025
weinbe58 merged 14 commits intomainfrom
exclusive-access-task

yzcj105 commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025 •

edited

Loading

Uh oh!

weinbe58 left a comment

Uh oh!

weinbe58 Apr 29, 2025

Uh oh!

weinbe58 Apr 29, 2025

Uh oh!

weinbe58 Apr 29, 2025

Uh oh!

weinbe58 Apr 29, 2025

Uh oh!

weinbe58 commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

codecov bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

yzcj105 commented Apr 30, 2025 •

edited

Loading

Uh oh!

jon-wurtz commented Apr 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants



		@ExclusiveRemoteTask.set_serializer

Comments

Conversation

yzcj105 commented Apr 29, 2025

Add exclusive access

Test

Waiting time

Uh oh!

github-actions bot commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weinbe58 left a comment

Choose a reason for hiding this comment

Uh oh!

weinbe58 Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

weinbe58 Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

weinbe58 Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

weinbe58 Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

weinbe58 commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

Uh oh!

codecov bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yzcj105 commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updates:

Test

Uh oh!

jon-wurtz commented Apr 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 29, 2025 •

edited

Loading

github-actions bot commented Apr 30, 2025 •

edited

Loading

codecov bot commented Apr 30, 2025 •

edited

Loading

yzcj105 commented Apr 30, 2025 •

edited

Loading