Merged
Conversation
Contributor
|
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
weinbe58
requested changes
May 2, 2025
Member
weinbe58
left a comment
weinbe58
left a comment
There was a problem hiding this comment.
Do not use recursion with an unbounded depth this is very bad practice.
src/bloqade/analog/task/exclusive.py
Outdated
| self._task_result_ir = self._http_handler.fetch_results(self._task_id) | ||
| else: | ||
| time.sleep(poll_interval) | ||
| self.pull(poll_interval) |
Member
There was a problem hiding this comment.
You can do this with a loop do not use recursion for with an unknown depth of the call stack.
Contributor
Author
There was a problem hiding this comment.
Okay I was wondering about this. I thought it would be okay because of the slow poll time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
pullmethod toExclusiveRemoteTask. The same asfetchexcept recursive after atime.sleepwith a poll time of 10 seconds.