Skip to content

Comments

Fix factory bug#1029

Merged
weinbe58 merged 3 commits intomainfrom
phil/fix-factory-bug
Jun 13, 2025
Merged

Fix factory bug#1029
weinbe58 merged 3 commits intomainfrom
phil/fix-factory-bug

Conversation

@weinbe58
Copy link
Member

@weinbe58 weinbe58 commented May 30, 2025

closes #1028

@weinbe58 weinbe58 changed the title Phil/fix factory bug Fix factory bug May 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-13 17:31 UTC

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bloqade/analog/factory.py 81.25% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8459 7455 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/analog/factory.py 93% 🟢
src/bloqade/analog/task/exclusive.py 35% 🟢
TOTAL 64% 🟢

updated for commit: cddf4bb by action🐍

@weinbe58 weinbe58 requested a review from johnzl-777 May 30, 2025 20:25
@weinbe58 weinbe58 merged commit ef89c4e into main Jun 13, 2025
8 checks passed
@weinbe58 weinbe58 deleted the phil/fix-factory-bug branch June 13, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems generating a Hamiltonian using rydberg_h: AttributeError: 'ListOfLocations' object has no attribute 'amplitude'

1 participant