Implement probability checks for native noise statements

[david-pl]

Closes #164

Note: still need to test it, blocked by the issue I have (similar to the one in #183 )

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
6222	5285	85%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
src/bloqade/noise/native/stmts.py	82%	🟢
TOTAL	82%	🟢

updated for commit: f3cac3e by action🐍

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/bloqade/noise/native/stmts.py	66.66%	9 Missing ⚠️

📢 Thoughts on this report? Let us know!

[david-pl]

After discussion with @weinbe58:
I added a test marked with xfail that expects an ir.ValidationError to trigger. The cause is that the overridden check methods are actually not called during verification. We'll wait for an update in kirin for that.

[weinbe58]

Could you create a shared implementation of the check put it outside the method? That would make testing a bit easier as well since you can check the implementation even if the statements do not run the verify.

[david-pl]

@weinbe58 I refactored things so now all the statements share the check. However, I still can't get the error to trigger in the CI, even after updating to kirin v0.17.2, even though I explicitly call .verify() on the kernel. What's also odd is that now I can't even trigger the error when overriding the verify method directly.

@Roger-luo here's a kirin MWE on v0.17.2 that also never triggers the error raised in check. Is that a bug?

from kirin import ir, lowering
from kirin.decl import statement
from kirin.prelude import basic_no_opt

dialect = ir.Dialect("foo")


@statement(dialect=dialect)
class InvalidStmt(ir.Statement):
    traits = frozenset({lowering.FromPythonCall()})

    def check(self):
        raise ValueError("Never triggers")


@ir.dialect_group(basic_no_opt.add(dialect))
def foo(self):
    def run_pass(mt):
        pass

    return run_pass


@foo
def test():
    InvalidStmt()


test.verify()

[weinbe58]

Just address the comments but LGTM.