Skip to content

Conversation

@david-pl
Copy link
Collaborator

No description provided.

@weinbe58
Copy link
Member

weinbe58 commented Apr 29, 2025

@david-pl The issue is that you are trying to use the qasm2.main dialect with the noise which isn't supported because we need ilist. if you use qasm2.extended it will actually execute beyond ilist.New. Also by default the analysis passes do not raise any exceptions, so to make sure you catch errors make sure to run the analysis with run_analysis(method,no_raise=False)

I've push an update to the test.

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6357 5482 86% 0% 🟢

New Files

File Coverage Status
src/bloqade/analysis/fidelity/_init_.py 100% 🟢
src/bloqade/analysis/fidelity/analysis.py 100% 🟢
src/bloqade/noise/fidelity.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
src/bloqade/noise/_init_.py 100% 🟢
TOTAL 100% 🟢

updated for commit: b29d8c4 by action🐍

@david-pl david-pl force-pushed the david/fidelity-analysis branch from ce3f68f to efc8546 Compare April 30, 2025 11:29
@david-pl david-pl marked this pull request as ready for review April 30, 2025 12:04
@david-pl david-pl requested review from Roger-luo and weinbe58 April 30, 2025 12:32
@david-pl david-pl requested a review from weinbe58 April 30, 2025 14:51
@david-pl david-pl force-pushed the david/fidelity-analysis branch from 772632b to 0922fdd Compare May 2, 2025 10:11
@david-pl david-pl requested a review from weinbe58 May 2, 2025 10:12
Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-pl david-pl merged commit 6a35f85 into main May 2, 2025
11 checks passed
@david-pl david-pl deleted the david/fidelity-analysis branch May 2, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants