Skip to content

Code Generation for QASM2 #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Nov 4, 2025
Merged

Code Generation for QASM2 #555

merged 42 commits into from
Nov 4, 2025

Conversation

@zhenrongliew
Copy link
Contributor

@zhenrongliew zhenrongliew commented Oct 20, 2025

Refactor QASM2's code generation to use the new Emit APIs.

@zhenrongliew
Refactor QASM codegen with new Interpreter framework. Still has linti…
4a31b16 
…ng errors
@zhenrongliew
Fixed codegen to match QASM2 function declaration syntax (classical b…
325faa0 
…its and quantum bits in/out of paranthesis).
@zhenrongliew
temp
9fbeac4
@zhenrongliew
Fixed linting
2889aff
@zhenrongliew
Fix invoke method type checking complain
7ff08c8
@zhenrongliew
included ssacfg in dialect groups
004e7e4
@zhenrongliew
Refactor SymbolTable implementation and remove unused test files
60c2852
@zhenrongliew
refactor STIM codegen to work with new API. updated STIM/emit test ca…
9831f65 
…ses to fit updated way of calling emit.
@zhenrongliew
Updated stim_circuit tests to new codegen
86a1ca4
@zhenrongliew
Refactor error handling to use InterpreterError instead of EmitError …
13c165e 
…and update related tests.
@zhenrongliew
Refactor run_analysis calls to use the updated run.
0c2172f
@zhenrongliew
added xfail for some (under refactoring) QASM2 codegen tests
5172e42
@kaihsin
Copy link
Contributor

kaihsin commented Oct 21, 2025

@zhenrongliew is this PR ready to review? the CI is failing tho

@zhenrongliew
Copy link
Contributor Author

zhenrongliew commented Oct 22, 2025

@zhenrongliew is this PR ready to review? the CI is failing tho

Seems like not yet. I will take a look at the failing tests

@zhenrongliew
Copy link
Contributor Author

zhenrongliew commented Oct 24, 2025

@Roger-luo @kaihsin It seems the CI is failiing because it cannot import "kirin.dialects.ssacfg". Is this because the CI is tied to Kirin 0.17?

@david-pl david-pl linked an issue Oct 27, 2025 that may be closed by this pull request
Upgrade codegen to new kirin version #573
Closed
@david-pl david-pl changed the base branch from main to david/571-kirin-upgrade-branch October 27, 2025 14:58
david-pl
david-pl reviewed Oct 28, 2025
View reviewed changes
@david-pl david-pl mentioned this pull request Oct 29, 2025
Merged
@zhenrongliew zhenrongliew marked this pull request as draft October 29, 2025 16:04
@zhenrongliew zhenrongliew marked this pull request as ready for review October 29, 2025 20:32
@zhenrongliew
Copy link
Contributor Author

zhenrongliew commented Oct 29, 2025

@Roger-luo @kaihsin, this is PR should be ready for review. The codegen for qasm2, stim, and cirq_utils now works for 0.20 Kirin.

The CI complaints is due to some changes in EmitABC (QuEraComputing/kirin#555) that's not yet in main Kirin.

Further errors are due to MeasureID and AddressAnalysis still being refactored.

@zhenrongliew zhenrongliew mentioned this pull request Oct 29, 2025
Merged
david-pl
david-pl reviewed Oct 30, 2025
View reviewed changes
Copy link
Collaborator

@david-pl david-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid.

@Roger-luo @kaihsin just remember when reviewing that we are not merging into main, but another intermediate branch. So failing tests are fine.

Roger-luo pushed a commit to QuEraComputing/kirin that referenced this pull request Nov 3, 2025
@zhenrongliew
Moved common fields from concrete class to abstract Emit class (#555)
2992835 
Simplified the code gen classes.

Moved the symbol table to `EmitABC`.
Moved `ssa` and `block` fields into base `EmitABC` class for
reusability. Also moved `run` method.
Changes made alongside
QuEraComputing/bloqade-circuit#555
kaihsin
kaihsin requested changes Nov 3, 2025
View reviewed changes
@david-pl david-pl merged commit 55686c3 into david/571-kirin-upgrade-branch Nov 4, 2025
7 of 10 checks passed
@david-pl david-pl deleted the dl/codegen branch November 4, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weinbe58 weinbe58 weinbe58 left review comments

@david-pl david-pl david-pl left review comments

@kaihsin kaihsin kaihsin approved these changes

@Roger-luo Roger-luo Awaiting requested review from Roger-luo

Assignees

@zhenrongliew zhenrongliew

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade codegen to new kirin version

5 participants

@zhenrongliew @kaihsin @weinbe58 @david-pl