Restructure and move qubit dialect #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
david-pl
added
the
breaking
This was
linked to
issues
Oct 21, 2025
Closed
johnzl-777
approved these changes
Oct 23, 2025
Contributor
johnzl-777
left a comment
johnzl-777
left a comment
There was a problem hiding this comment.
LGTM! Just a dangling print statement and some (very) minor nitpicks. Thank you for doing this!
| ctrls: ir.SSAValue = info.argument(ilist.IListType[qubit.QubitType, N]) | ||
| qargs: ir.SSAValue = info.argument(ilist.IListType[qubit.QubitType, N]) | ||
| ctrls: ir.SSAValue = info.argument(ilist.IListType[QubitType, N]) | ||
| qargs: ir.SSAValue = info.argument(ilist.IListType[QubitType, N]) |
Contributor
There was a problem hiding this comment.
I know this isn't part of the PR (so feel free to just resolve this) but I'm curious, why is it a qarg here when we usually do something like controls vs. targets?
Collaborator
Author
There was a problem hiding this comment.
Oh, that was introduced by @weinbe58 somewhere. I think I even left a similar comment on the PR? Should we change it? (Not in this PR, of course).
Collaborator
Author
|
CI is now failing because of #566 :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #549, this restructures the qubit dialect. I also moved it to the top level of bloqade, since it's used in multiple places. It's still re-exported by squin, though.
I've got it down to a single failing test, where the
AggressiveUnrollfails because the constant propagation doesn't hint the loop iterable as constant for some reason.This breaks the syntax such that you have to change the function calls using lists such as
squin.qubit.measure(q: IList[Qubit])tosquin.broadcast.measure(q: IList[Qubit]).Edit: turns out I was just too eager to remove the type inference method @weinbe58 added in #508. That resolves the failing test.
Edit2: I've also changed
QubitIdandMeasurementIdto be "broadcasted" (i.e., they now operate on lists of qubits / measurements and return lists). This means that now all statements exceptqubit.neware broadcasted, which is as consistent as we can have it, I think.