-
Notifications
You must be signed in to change notification settings - Fork 1
Adjust AggressiveUnroll to fix type error during unroll #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Probably do not backport. This could cause changes in the output IR although it shouldn't make any functional changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
weinbe58
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to investigate your issues later but lets merge this for now.
| DeadCodeElimination(), | ||
| ) | ||
| result = Fixpoint(Walk(rule)).rewrite(mt.code).join(result) | ||
| result = Walk(rule).rewrite(mt.code).join(result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I guess CSE doesn't have to be run as a fixed point.
@weinbe58 This is the same issue you helped me debug on the 24th. |
I'm not sure what was causing the error but rearranging the passes with the help of @weinbe58 fixed the problem.
For context, this was the error. I did not find a MWE.