Skip to content

Conversation

@weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Dec 1, 2025

This PR closes #634 . The implementation is very simple, just track the values of the body-frame joining them after every sincle iteration on the for loop.

@weinbe58 weinbe58 linked an issue Dec 1, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bloqade/analysis/address/impls.py 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@johnzl-777 johnzl-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Only 5 lines!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10195 8950 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/analysis/address/impls.py 82% 🟢
TOTAL 82% 🟢

updated for commit: 394f240 by action🐍

@johnzl-777 johnzl-777 merged commit 65cbc8d into main Dec 1, 2025
10 of 12 checks passed
@johnzl-777 johnzl-777 deleted the phil/update-loop-body branch December 1, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make AddressAnalysis data available in scf.for loop bodies

3 participants