Non-Clifford to U3 rewrite. #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified FilesNo covered modified files...
|
david-pl
approved these changes
Dec 5, 2025
Collaborator
david-pl
left a comment
david-pl
left a comment
There was a problem hiding this comment.
Looks good, just one small comment.
david-pl
pushed a commit
that referenced
this pull request
Dec 9, 2025
In order to canonicalize squin to be lowered to the compiler pipeline I am adding this rewrite to make sure all non-clifford gates are U3 gates in order to specialize later to initialization of the logical qubits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to canonicalize squin to be lowered to the compiler pipeline I am adding this rewrite to make sure all non-clifford gates are U3 gates in order to specialize later to initialization of the logical qubits.