Skip to content

Conversation

@johnzl-777
Copy link
Contributor

@johnzl-777 johnzl-777 commented Dec 5, 2025

@david-pl pointed out to me that the current integer-bounded type variables for the Gemini TerminalLogicalMeasurement statement cause the type checker to yell in perfect valid kernels:

@gemini.logical.kernel
def trivial_kernel():
	qs = squin.qalloc(5)
	tm = gemini.logical.terminal_measure(qs)
	return tm

I resolved this with input from @weinbe58 to still keep the type variables but remove the bound. The "aggressive" behavior on the typechecking is an inherent Kirin limitation

@johnzl-777 johnzl-777 requested a review from david-pl December 5, 2025 15:51
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10477 9216 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/gemini/dialects/logical/_interface.py 100% 🟢
src/bloqade/gemini/dialects/logical/stmts.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 22ab6e4 by action🐍

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@johnzl-777 johnzl-777 merged commit b35ad15 into main Dec 5, 2025
11 of 12 checks passed
@johnzl-777 johnzl-777 deleted the john/relax-terminal-measure-type-bound branch December 5, 2025 16:26
david-pl pushed a commit that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants