Intermediate statement based REPEAT support#723
Draft
johnzl-777 wants to merge 3 commits intomainfrom
Draft
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another approach to #630 that @weinbe58 proposed where instead of trying to have a global state in the frame that tracks all lattice elements and updates them (along with the unusual "detachment/immutability" mechanism), a partial rewrite is done with a kind of disposable dialect that makes it easier to calculate and retain the proper record index.
This should allow the MeasurementIDAnalysis to also not be forced to follow the negative indexing convention. This effectively decouples the intent of analysis which is strictly to count the number of measurements from the record index rewrite