-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add MLE (Gurobi) and MLD (Table) decoders with Sinter adapters #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChenZhao44
wants to merge
21
commits into
main
Choose a base branch
from
chen/mle-mld
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c90f30e
chore: add optional dependency groups for mle, mld, and sinter decoders
ChenZhao44 4cca425
test: add failing tests for GurobiDecoder (RED)
ChenZhao44 52eda7f
feat: implement GurobiDecoder (MLE) migrated from brute-force-decoder…
ChenZhao44 3c7d385
test: add failing tests for TableDecoder (RED)
ChenZhao44 97baadb
feat: implement TableDecoder (MLD) migrated from brute-force-decoders…
ChenZhao44 7a205ea
test: add failing tests for Sinter adapters (RED)
ChenZhao44 3fd56ff
feat: add sinter adapters inline in mle.py and mld.py (GREEN)
ChenZhao44 5f0adf9
test: add GurobiDecoder to parametrized tests and new export assertions
ChenZhao44 cbdcb5f
refactor: move sinter tests into test_mle.py and test_mld.py
ChenZhao44 c5cfccd
refactor: address code review for MLE/MLD decoders
ChenZhao44 0cac4fe
fix: resolve CI failures for Python 3.10 compat, isort, and black
ChenZhao44 9459b15
fix: black formatting in test_mle.py and test_mld.py
ChenZhao44 0230db2
test: improve MLE/MLD coverage from 92% to 94%
ChenZhao44 42a86e8
fix: address PR review comments for MLE/MLD decoders
ChenZhao44 5a3e5df
fix: black formatting in test_mle.py
ChenZhao44 c203946
fix: black formatting in test files
ChenZhao44 4c42c95
refactor: remove generate_conditional_decoder from GurobiDecoder
ChenZhao44 eec83b2
fix lint
ChenZhao44 a2f158d
add test for the case when errors are not a the first block
ChenZhao44 6defc6e
refactor: address PR review comments for MLE/MLD decoders
ChenZhao44 3305a35
fix: handle probability 0.0 and 1.0 edge cases in GurobiDecoder
ChenZhao44 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.