fix(search): resolve backward AOD rectangle source mapping#462
Open
Jason-Ludmir wants to merge 2 commits intomainfrom
Open
fix(search): resolve backward AOD rectangle source mapping#462Jason-Ludmir wants to merge 2 commits intomainfrom
Jason-Ludmir wants to merge 2 commits intomainfrom
Conversation
Build bus-context rectangle sources from direction-aware lane endpoints and preserve source-to-lane mappings when emitting lane sets. Add a regression test for backward word-bus source coordinates to prevent valid parallel backward moves from being split. Made-with: Cursor
Jason-Ludmir
added
area: Lane
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src_to_lanemap so rectangle emission reuses valid lane identities instead of reconstructing potentially invalid backward lanesTest plan
uv run pytest python/tests/search/test_greedy_generator.pydebug/steane_physical_impl.py --gifand confirm the previously split backward rows are mergedCloses #460
Made with Cursor