Fix circular import error. issue #549 #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
kaihsin
requested changes
Oct 28, 2025
Collaborator
kaihsin
left a comment
kaihsin
left a comment
There was a problem hiding this comment.
can you put rewrite under dialects/func/rewrite, similar to dialects/ilist ?
…similar to `dialects/ilist/rewrite/`
Contributor
Author
Moved. Updated init.py and tests. |
kaihsin
requested changes
Oct 28, 2025
… TypeInfer back to top-level.
kaihsin
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in issue #549: circular import error when importing
kirin.dialects.py.Small edits to
src/kirin/dialects/func/closurefield.pyandsrc/kirin/dialects/func/lambdalifting.py.Delaying import.