Skip to content

Conversation

@rafaelha
Copy link
Contributor

This reverts commit dfcd096.

This removes SliceAttribute which was introduced to support hashing (for CSE).

Closes #559

@rafaelha rafaelha requested a review from weinbe58 October 31, 2025 18:10
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kirin/dialects/py/slice.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-31 18:13 UTC

@github-actions
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11466 10210 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/dialects/py/indexing.py 90% 🟢
src/kirin/dialects/py/slice.py 94% 🟢
src/kirin/types.py 100% 🟢
TOTAL 95% 🟢

updated for commit: 8eda3bc by action🐍

@weinbe58 weinbe58 added the breaking breaking changes or proposed changes that would break existing APIs label Oct 31, 2025
@weinbe58 weinbe58 merged commit b727b55 into main Oct 31, 2025
12 of 13 checks passed
@weinbe58 weinbe58 deleted the rafaelha/roll_back_SliceAttribute branch October 31, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking breaking changes or proposed changes that would break existing APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SliceAttribute fails in constant prop

3 participants