Skip to content

add scalar/vector binops to vmath #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Roger-luo merged 12 commits into from
Nov 6, 2025
Merged

add scalar/vector binops to vmath #568

Roger-luo merged 12 commits into from
Nov 6, 2025

Conversation

@neelay893
Copy link
Contributor

@neelay893 neelay893 commented Nov 5, 2025

  • Implement add, sub, div, and mult binops for vmath dialect. These are (vector, vector), (scalar, vector), (vector, scalar).
  • Add rewrite pass to convert the corresponding python operators (+, -, *, /) between IList and scalar to their vmath implementation.

@neelay893 neelay893 requested a review from kaihsin November 5, 2025 20:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11595 10333 89% 0% 🟢

New Files

File Coverage Status
src/kirin/dialects/vmath/passes.py 100% 🟢
src/kirin/dialects/vmath/rewrites/_init_.py 100% 🟢
src/kirin/dialects/vmath/rewrites/desugar.py 89% 🟢
TOTAL 96% 🟢

Modified Files

File Coverage Status
src/kirin/dialects/vmath/_init_.py 100% 🟢
src/kirin/dialects/vmath/interp.py 100% 🟢
src/kirin/dialects/vmath/stmts.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 0098cfc by action🐍

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 96.63866% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kirin/dialects/vmath/rewrites/desugar.py 88.57% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025 •
edited
Loading

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-11-06 15:43 UTC

@Roger-luo Roger-luo merged commit 122ced6 into main Nov 6, 2025
13 checks passed
@Roger-luo Roger-luo deleted the neelay/vmath-upgrades branch November 6, 2025 15:43
@neelay893 neelay893 mentioned this pull request Nov 7, 2025
Merged
Roger-luo pushed a commit that referenced this pull request Nov 19, 2025
@neelay893
register vmath desugar as post inference and remove pass (#573)
d133226 
- vmath desugar rewrite (#568) is now registered as a vmath dialect
post-inference rewrite rule
- remove vmath/passes.py as it is no longer needed

These changes are separate from (#568) since they are not compatible
with kirin 0.17 (in case we want to backport).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaihsin kaihsin Awaiting requested review from kaihsin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neelay893 @Roger-luo