Skip to content

Fix match_rating comparison algorithm#28

Merged
esensar merged 2 commits intomainfrom
fix/match-rating-calculation
Mar 24, 2026
Merged

Fix match_rating comparison algorithm#28
esensar merged 2 commits intomainfrom
fix/match-rating-calculation

Conversation

@esensar
Copy link
Copy Markdown
Collaborator

@esensar esensar commented Mar 18, 2026

Fixes: #17

@esensar
Copy link
Copy Markdown
Collaborator Author

esensar commented Mar 19, 2026

While this aligns the code to the algorithm description, yelp and paypal are still a match. I only once got a mismatch, because I accidentally stopped iteration before the last character.

@esensar esensar merged commit a170e6e into main Mar 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

match_string rule seems to have high (or 100%?) false positives

1 participant