Skip to content

set BP policy default max duration to unlimited #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnathanvidu merged 1 commit into from
Apr 28, 2025
Merged

set BP policy default max duration to unlimited #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/provider/resources/torque_catalog_item_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func (r *TorqueCatalogItemResource) Create(ctx context.Context, req resource.Cre
data.DefaultDuration = types.StringNull()
} else {
if data.MaxDuration.IsNull() || data.MaxDuration.IsUnknown() {
data.MaxDuration = types.StringValue("PT2H")
data.MaxDuration = types.StringNull()
}
if data.DefaultExtend.IsNull() || data.DefaultExtend.IsUnknown() {
data.DefaultExtend = types.StringValue("PT2H")
Expand Down Expand Up @@ -330,7 +330,7 @@ func (r *TorqueCatalogItemResource) Update(ctx context.Context, req resource.Upd
data.DefaultDuration = types.StringNull()
} else {
if data.MaxDuration.IsNull() || data.MaxDuration.IsUnknown() {
data.MaxDuration = types.StringValue("PT2H")
data.MaxDuration = types.StringNull()
}
if data.DefaultExtend.IsNull() || data.DefaultExtend.IsUnknown() {
data.DefaultExtend = types.StringValue("PT2H")
Expand Down Expand Up @@ -420,7 +420,7 @@ func (r *TorqueCatalogItemResource) Delete(ctx context.Context, req resource.Del
return
}

data.MaxDuration = types.StringValue("PT2H")
data.MaxDuration = types.StringNull()
data.DefaultExtend = types.StringValue("PT2H")
data.DefaultDuration = types.StringValue("PT2H")

Expand Down
2 changes: 1 addition & 1 deletion internal/provider/tests/catalog_item_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func TestCatalogItemResource(t *testing.T) {
resource.TestCheckResourceAttr("torque_catalog_item.catalog_item", "always_on", "false"),
resource.TestCheckResourceAttr("torque_catalog_item.catalog_item", "default_duration", "PT2H"),
resource.TestCheckResourceAttr("torque_catalog_item.catalog_item", "default_extend", "PT2H"),
resource.TestCheckResourceAttr("torque_catalog_item.catalog_item", "max_duration", "PT2H"),
resource.TestCheckNoResourceAttr("torque_catalog_item.catalog_item", "max_duration"),
resource.TestCheckResourceAttr("torque_catalog_item.catalog_item", "labels.#", "2"),
testBlueprintPublished(new_unique_blueprint_name),
),
Expand Down
Loading