feat: Generate sitemaps using next-sitemap #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
requested review from
galdranorn,
kherma and
mstoczkowski
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I may need help figuring out how to tie the build and sitemap tasks together. Right now, with this PR, they have to be run one after the other. |
|
Note to self: if this solution proves too inflexible or difficult to properly configure, it may be easier to create a sitemap component that works a bit like generateRSS.ts. |
gabalafou
commented
Jun 27, 2022
| "executor": "@nrwl/workspace:run-commands", | ||
| "outputs": [], | ||
| "options": { | ||
| "command": "next-sitemap --config apps/consulting/next-sitemap.config.js" |
There was a problem hiding this comment.
@marcin-antczak-naturaily can we make this a part of the build step so that /sitemap.xml gets deployed with each Vercel deploy?
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add npm package
next-sitemapalong with configuration needed to generate site maps for Consulting and Labs sites.This is a first step to running pa11y against all of the pages on the websites. As such, it is a step toward closing the following issues: #152, #153, #154, and #156.
This code was largely patterned after code in the repo that generates the nx.dev website: https://github.com/nrwl/nx/blob/master/nx-dev/nx-dev/project.json#L19
How to test locally
Consulting:
Labs:
To do
nx build consulting, sitemap.xml is output into the public folder<changefreq>and<priority>from sitemap.xml if they have unintended consequences and are not needednpm run start