Make blog title h1 not h2 #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blog title displayed on the page should be wrapped in an
<h1>not an<h2>.Note: yes, this means that some blog posts will have two or more h1's. This will occur for blog posts in which the author used one or more level-1 markdown headings. Level-1 headings are the ones with a single hash (#) sign at the beginning of the line. But those are in the minority, and this fixes headings for most of the Labs blog posts. Plus for the blog posts in the minority, the headings were already broken, out of order. They would start with an h2, followed by an h1. Now it starts with an h1 followed by an h1. Not ideal but arguably less broken than before. A follow up PR (#874) will attempt to fix those blog posts.