-
Notifications
You must be signed in to change notification settings - Fork 10
Introduce build workflow with pixi
.
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hameerabbasi I am holding this for now pending a discussion about the future of our tooling in here. My thoughts:
|
This ideally requires pytorch/benchmark#2622 to be merged first. One caveat here is that One solution is to have a separate |
Done! It now supports all the YAML files in the original repo.
I would too, the only caveat being in #34 (comment). |
echo "source $SCRIPT_DIR/torch-common.sh" > $CONDA_PREFIX/etc/conda/activate.d/activate-torch.sh | ||
echo "source $SCRIPT_DIR/deactivate-torch-common.sh" > $CONDA_PREFIX/etc/conda/activate.d/deactivate-torch.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to make sure the environment is set up properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With conda
, yes. But if you look at the following lines; pixi
will take care of that for us. I'm calling the script inside the activation.scripts
section of pixi.toml
.
Lines 18 to 19 in 9634e20
[activation] | |
scripts = ["./torch-common.sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about deactivation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pixi tasks are generally run under a new shell process with pixi shell
or pixi run
instead of in the same process. Thus the deactivation cleanup isn't needed. One CAN use the same shell with eval "$(pixi shell-hook)"
, but that's a fringe use-case.
No description provided.