Skip to content

Conversation

@Marinovsky
Copy link
Contributor

Description

Remove fill warnings from tags because they are already in the fill events

Related Issue

Closes #8517

Motivation and Context

With this change, order tags will have no more redundant fill warnings information

Requires Documentation Change

N/A

How Has This Been Tested?

There was already one unit test asserting the fill warning message, in the order's tag, was correct. Since we are removing those warnings from the orders tags, we are also deleting that test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 980cdea into QuantConnect:master Apr 3, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove fill warnings on order tags

2 participants