Skip to content

Conversation

@Romazes
Copy link
Collaborator

@Romazes Romazes commented Apr 4, 2025

Description

Change the access modifier in OptionCodeLookup to use it in different modules.

Related Issue

N/a

Motivation and Context

Reusing code is always great.

Requires Documentation Change

N/a

How Has This Been Tested?

  • Use this collection in some SymbolMapper.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes added the feature label Apr 4, 2025
@Romazes Romazes requested a review from Martin-Molinero April 4, 2025 14:21
@Romazes Romazes self-assigned this Apr 4, 2025
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Martin-Molinero Martin-Molinero merged commit e1cd636 into QuantConnect:master Apr 7, 2025
6 of 8 checks passed
@Romazes Romazes deleted the refactor-symbol-representation-option-code-lookup branch July 14, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants