Skip to content

Conversation

@Romazes
Copy link
Collaborator

@Romazes Romazes commented Apr 4, 2025

Description

Missed OrderStatus in OrderTestParameters. When we create a test order in brokerage, OrderStatus is always equal to None. This is incorrect because when we create a new Lean Order, it must have OrderStatus = New.

Related Issue

N/a

Motivation and Context

Fix bugs and simplify the process of testing in microservices.

Requires Documentation Change

N/a

How Has This Been Tested?

  • Launch test in brokerage and inspect their order status before Status is not Submitted.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes added the bug label Apr 4, 2025
@Romazes Romazes requested a review from Martin-Molinero April 4, 2025 14:25
@Romazes Romazes self-assigned this Apr 4, 2025
@Martin-Molinero Martin-Molinero merged commit 87487ec into QuantConnect:master Apr 7, 2025
7 of 8 checks passed
@Romazes Romazes deleted the feature-missed-order-status-in-brokerage-test-order-parameters branch July 14, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants