Skip to content

Change Config.Get logging from Trace to Debug level #9171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martin-Molinero merged 2 commits into from
Dec 31, 2025
Merged

Change Config.Get logging from Trace to Debug level #9171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52c3c7d
Change Config.Get logs from Trace to Debug level to reduce noise
JosueNina Dec 30, 2025
5b07c8c
Wrap Config.Get logs with DebuggingEnabled check
JosueNina Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions Configuration/Config.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,10 @@ public static string Get(string key, string defaultValue = "")
var token = GetToken(Settings.Value, key);
if (token == null)
{
Log.Trace(Invariant($"Config.Get(): Configuration key not found. Key: {key} - Using default value: {defaultValue}"));
if (Log.DebuggingEnabled)
{
Log.Debug(Invariant($"Config.Get(): Configuration key not found. Key: {key} - Using default value: {defaultValue}"));
}
return defaultValue;
}
return token.ToString();
Expand Down Expand Up @@ -227,18 +230,21 @@ public static double GetDouble(string key, double defaultValue = 0.0)
public static T GetValue<T>(string key, T defaultValue = default(T))
{
// special case environment requests
if (key == "environment" && typeof (T) == typeof (string)) return (T) (object) GetEnvironment();
if (key == "environment" && typeof(T) == typeof(string)) return (T)(object)GetEnvironment();

var token = GetToken(Settings.Value, key);
if (token == null)
{
var defaultValueString = defaultValue is IConvertible
? ((IConvertible) defaultValue).ToString(CultureInfo.InvariantCulture)
? ((IConvertible)defaultValue).ToString(CultureInfo.InvariantCulture)
: defaultValue is IFormattable
? ((IFormattable) defaultValue).ToString(null, CultureInfo.InvariantCulture)
? ((IFormattable)defaultValue).ToString(null, CultureInfo.InvariantCulture)
: Invariant($"{defaultValue}");

Log.Trace(Invariant($"Config.GetValue(): {key} - Using default value: {defaultValueString}"));
if (Log.DebuggingEnabled)
{
Log.Debug(Invariant($"Config.GetValue(): {key} - Using default value: {defaultValueString}"));
}
return defaultValue;
}

Expand All @@ -255,22 +261,22 @@ public static double GetDouble(string key, double defaultValue = 0.0)

if (type.IsEnum)
{
return (T) Enum.Parse(type, value, true);
return (T)Enum.Parse(type, value, true);
}

if (typeof(IConvertible).IsAssignableFrom(type))
{
return (T) Convert.ChangeType(value, type, CultureInfo.InvariantCulture);
return (T)Convert.ChangeType(value, type, CultureInfo.InvariantCulture);
}

// try and find a static parse method
try
{
var parse = type.GetMethod("Parse", new[]{typeof(string)});
var parse = type.GetMethod("Parse", new[] { typeof(string) });
if (parse != null)
{
var result = parse.Invoke(null, new object[] {value});
return (T) result;
var result = parse.Invoke(null, new object[] { value });
return (T)result;
}
}
catch (Exception err)
Expand Down Expand Up @@ -381,7 +387,7 @@ public static JObject Flatten(JObject config, string overrideEnvironment)
var environments = config["environments"];
if (!(environments is JObject)) continue;

var settings = ((JObject) environments).SelectToken(env);
var settings = ((JObject)environments).SelectToken(env);
if (settings == null) continue;

// copy values for the selected environment to the root
Expand All @@ -395,7 +401,7 @@ public static JObject Flatten(JObject config, string overrideEnvironment)
var jProperty = clone.Property(path);
if (jProperty != null) jProperty.Remove();

var value = (token is JProperty ? ((JProperty) token).Value : token).ToString();
var value = (token is JProperty ? ((JProperty)token).Value : token).ToString();
clone.Add(path, value);
}
}
Expand Down