Skip to content

Fix collapse functionality bugs: CSS selectors, height parsing, and toggle bar creation #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmcky merged 15 commits into from
Sep 24, 2025
Merged

Fix collapse functionality bugs: CSS selectors, height parsing, and toggle bar creation #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1865437
Initial plan
Copilot Aug 18, 2025
bbfa33d
Initial analysis - understand collapse-## styling issue
Copilot Aug 18, 2025
489ca0e
Fix collapse-## styling by removing hardcoded height
Copilot Aug 18, 2025
5aaa9cb
Implement single bottom bar collapse toggle for better UX
Copilot Aug 23, 2025
af6d9a2
Relax Python version requirement from 3.13 to >=3.12 and update test …
Copilot Aug 25, 2025
c19800e
fix trim white space pre-commit
mmcky Aug 25, 2025
5e7f2f1
Merge branch 'main' into copilot/fix-299
mmcky Aug 25, 2025
ca3fa57
Fix collapse functionality - correct CSS selectors and height parsing…
Copilot Aug 25, 2025
f2b4a95
Merge main into copilot/fix-299 - resolve conflicts with GitHub Actio…
Copilot Sep 23, 2025
52fb314
Merge branch 'main' into copilot/fix-299
mmcky Sep 23, 2025
c25699d
Simplify collapse button text and add scroll behavior when collapsing
Copilot Sep 23, 2025
497f484
fix: pre-commit
mmcky Sep 23, 2025
76d70ff
Improve collapse scroll behavior with better timing and comments
Copilot Sep 23, 2025
ee7296e
Make collapse button text bold for better visibility
Copilot Sep 23, 2025
b8ff52c
fix pre-commit
mmcky Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.13"]
python-version: ["3.12", "3.13"]
# Only test the latest major release of Sphinx because otherwise we need to
# keep multiple versions of regression tests on file and this creates lots of
# noise in the tests.
Expand All @@ -48,7 +48,7 @@ jobs:
pytest --durations=10 --cov=quantecon_book_theme --cov-report=xml --cov-report=term-missing

- name: Upload to Codecov
if: matrix.os == 'ubuntu-latest' && matrix.python-version == 3.13 && github.repository == 'QuantEcon/quantecon-book-theme' && github.event_name == 'pull_request'
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.13' && github.repository == 'QuantEcon/quantecon-book-theme' && github.event_name == 'pull_request'
uses: codecov/[email protected]
with:
name: ebp-qbt-pytests-py3.13
Expand Down
Loading
Loading