-
-
Notifications
You must be signed in to change notification settings - Fork 23
FEAT: Execute downloaded notebooks #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks @AakashGfude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @AakashGfude this looks great. If you have tested it I am happy to merge.
@mmcky testing on |
@AakashGfude would you mind to test on |
@arnavs would you have time to give this branch a try on the |
@mmcky Sure, will give this a go in the next few hours. |
@AakashGfude when I tested this on the <li><a href="https://lectures.quantecon.org/multi_agent_models/index.html">Multiple Agent Models</a><ul>
<li><a href="https://lectures.quantecon.org/multi_agent_models/schelling.html">Schelling’s Segregation Model</a></li> should be more like <li><a href="getting_started_julia/index.html">Getting Started with Julia</a><ul>
<li><a href="getting_started_julia/getting_started.html">Setting up Your Julia Environment</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be a bug when forming index.html
using this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AakashGfude this is working well for me now.
@arnavs would you mind doing a test on your end for Julia
Just started a test on this and |
Maybe it's just me, but I find two things:
I set the |
thanks @arnavs your second point is an issue with @AakashGfude can you look into the first point raised? |
@arnavs regarding point |
@mmcky Maybe that was it. I'm looking through this PR and I don't see anything troublesome, so I'm willing to take the plunge. This will be a great help on the Julia side. |
@AakashGfude we need to update this so that if |
…rom executed downloads
@mmcky done. Testing it now |
thanks @AakashGfude this is looking good now. Once your testing is complete and your happy with it -- let me know and I will merge and release |
This PR implements the feature to execute notebooks in
_downloads
folder.To enable this feature, one has to set
jupyter_download_nb_execute
variable toTrue
in config