Skip to content

Add support for solution images #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for solution images #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b9ec2
Add support for solution images
arneki Apr 26, 2021
ef7a1af
Add test for solution images
arneki Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sphinxcontrib/jupyter/writers/translate_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,9 @@ def visit_image(self, node):
### preventing image from the index file at the moment
if self.in_book_index:
return
### Skip solutions if we say to
if "solution" in node.attributes['classes'] and self.jupyter_drop_solutions:
return
uri = node.attributes["uri"]
self.images.append(uri) #TODO: list of image files
if self.jupyter_download_nb_image_urlpath:
Expand Down
3 changes: 3 additions & 0 deletions tests/base/solutions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,6 @@ when :math:`x \in [0,1]`
ax.fill(x, y, zorder=10)
ax.grid(True, zorder=5)
plt.show()

.. image:: _static/hood.jpg
:class: solution