Add colours to status subcommand #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
requested changes
Sep 1, 2025
src/subcommand/log_subcommand.cpp
Outdated
| @@ -54,7 +54,7 @@ void print_commit(const commit_wrapper& commit, std::string m_format_flag) | |||
| signature_wrapper author = signature_wrapper::get_commit_author(commit); | |||
| signature_wrapper committer = signature_wrapper::get_commit_committer(commit); | |||
|
|
|||
| std::cout << "\033[0;33m" << "commit " << buf << "\033[0m" << std::endl; | |||
| std::cout << message_colour.at("yellow") << "commit " << buf << message_colour.at("colour_close") << std::endl; | |||
There was a problem hiding this comment.
Nice to see use of colour rather than color!
src/subcommand/status_subcommand.cpp
Outdated
| { | ||
| for (auto e: entries_to_print) | ||
| { | ||
| std::cout << e.status << e.item << std::endl; | ||
| if (is_long) | ||
| std::cout << colour << e.status << e.item << message_colour.at("colour_close") << std::endl; |
There was a problem hiding this comment.
Should this line be indented a few spaces? And the line 2 below this.
ianthomas23
requested changes
Sep 4, 2025
src/subcommand/status_subcommand.cpp
Outdated
| if (sl.has_tobecommited_header()) | ||
| { | ||
| stream_colour_fn colour = termcolor::green; |
There was a problem hiding this comment.
There's an unnecessary double space here.
|
Note to self: need to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add colours to status subcommand