Skip to content

Update location extraction logic #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DenisaCG merged 2 commits into from
Dec 16, 2024
Merged

Update location extraction logic #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1e6c8b
update location extraction logic
DenisaCG Dec 16, 2024
b76c017
iterate on location extraction
DenisaCG Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions jupyter_drives/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,12 +547,13 @@ async def _get_drive_location(self, drive_name):
Args:
drive_name: name of drive to get the region of
"""
location = 'eu-north-1'
location = 'us-east-1'
try:
# set temporary client for location extraction
async with self._s3_session.create_client('s3', aws_secret_access_key=self._config.secret_access_key, aws_access_key_id=self._config.access_key_id, aws_session_token=self._config.session_token) as client:
result = await client.get_bucket_location(Bucket=drive_name)
location = result['LocationConstraint']
if result['LocationConstraint'] is not None:
location = result['LocationConstraint']
except Exception as e:
raise tornado.web.HTTPError(
status_code= httpx.codes.BAD_REQUEST,
Expand Down
Loading