Replace launcher plugin #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
afshin
approved these changes
Dec 18, 2024
Member
afshin
left a comment
afshin
left a comment
There was a problem hiding this comment.
Thank you! Let's get this upstream in JupyterLab so that it's only temporary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
JupyterLabprovided plugin@jupyterlab/launcher-extension:pluginand provides its own, such that the launcher creates the selected item either in the defaultFileBrowserwith the local storage or theDriveFileBrowserwithin the available drives.The
IFileBrowserFactoryis used to get the current file browser used when opening it. It defaults to theDriveBrowserwhen first launchingJupyterLabas it get the recently added file browser, if none was in focus.It should provide a temporary fix for this issue: #45.