Skip to content

Conversation

@Hind-M
Copy link
Member

@Hind-M Hind-M commented Dec 5, 2025

This is fixing the MSVC failure on windows builds (from conda-forge and on debug).
The error is the following:

> MSBuild version 17.14.23+b0019275e for .NET Framework

    Checking File Globs
    1>Ensuring FlatBuffers headers are generated
    sparrow-ipc.vcxproj -> D:\a\sparrow-ipc\sparrow-ipc\build\bin\sparrow-ipc.dll
    test_sparrow_ipc_lib.vcxproj -> D:\a\sparrow-ipc\sparrow-ipc\build\bin\test_sparrow_ipc_lib.exe
    Copying required DLLs to executable directory
    Running tests with JUnit reports saved to: D:/a/sparrow-ipc/sparrow-ipc/build/tests/test_sparrow-ipc_lib_report_doctest.xml
    C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_ranges_to.hpp(688) : Assertion failed: cannot compare incompatible transform_view iterators
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for
  'D:\a\sparrow-ipc\sparrow-ipc\build\CMakeFiles\6c8cda2a2ce3cc391a11984304f7080f\run_tests_with_junit_report.rule;D:\a\sparrow-ipc\sparrow-ipc\tests\CMakeLists.txt' exited with code -1073740791. [D:\a\sparrow-ipc\sparrow-ipc\build\tests\run_tests_with_junit_report.vcxproj] still
  the same problem

This happened once the CI started using sparrow-devel 1.4.0, specifically due to changes in this PR where record_batch::columns() is now using std::views::transform.

I don't know the rationale behind this change, specifically whether it involves using std::views::transform to handle record batch arrays as references, or whether we could change this approach.
If the latter is true, maybe add a TODO note here to change it back to how things were handled.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b00c770). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage        ?   82.35%           
=======================================
  Files           ?       35           
  Lines           ?     1746           
  Branches        ?        0           
=======================================
  Hits            ?     1438           
  Misses          ?      308           
  Partials        ?        0           
Flag Coverage Δ
unittests 82.35% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hind-M Hind-M marked this pull request as ready for review December 5, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants