Attempt to fix MSVC failure #66
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the MSVC failure on windows builds (from conda-forge and on debug).
The error is the following:
This happened once the CI started using
sparrow-devel 1.4.0, specifically due to changes in this PR whererecord_batch::columns()is now usingstd::views::transform.I don't know the rationale behind this change, specifically whether it involves using
std::views::transformto handle record batch arrays as references, or whether we could change this approach.If the latter is true, maybe add a
TODOnote here to change it back to how things were handled.