Add polars tests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/check_deps.py
Outdated
| sys.exit(1) | ||
|
|
||
| print("\nAll dependencies installed!") | ||
| sys.exit(0) |
Member
There was a problem hiding this comment.
I think we can drop this file, the dependencies are already in the environment file and the error message when an import fail is quite clear.
test/test_library_load.py
Outdated
| return 1 | ||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) |
Member
There was a problem hiding this comment.
Same remark as for check_deps, not sure we need this file.
| # Set environment variables so Python can find the libraries | ||
| # Use generator expressions to get the actual library paths from targets | ||
| set_tests_properties(test_sparrow_integration PROPERTIES | ||
| ENVIRONMENT "TEST_SPARROW_HELPER_LIB_PATH=$<TARGET_FILE:test_sparrow_helper>;SPARROW_PYCAPSULE_LIB_PATH=$<TARGET_FILE:sparrow-pycapsule>" |
Member
There was a problem hiding this comment.
I would prefer that we avoid using environment variables for testing, and use an approach similar to pybind11 instead. That can be done in a dedicated PR when we make this repo a real Python package though.
Member
Author
There was a problem hiding this comment.
Ok, let's do that in another PR
JohanMabille
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.