Skip to content

Missing register comm target #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidbrochart merged 2 commits into from
Jan 31, 2025
Merged

Missing register comm target #37

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adaf190
Missing register comm target
martinRenou Jan 31, 2025
c33474a
Linting
martinRenou Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ypywidgets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@
__version__ = importlib.metadata.version("ypywidgets")
except importlib.metadata.PackageNotFoundError: # pragma: no cover
__version__ = "unknown"


from .comm import register_comm_target

register_comm_target()
11 changes: 11 additions & 0 deletions src/ypywidgets/comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@
from .widget import Widget


def handle_comm_opened(*args, **kwargs):
# TODO handle comm open from front-end
pass


def register_comm_target():
comm_manager = comm.get_comm_manager()
if comm_manager is not None:
comm_manager.register_target('ywidget', handle_comm_opened)


def create_widget_comm(
data: dict | None = None,
metadata: dict | None = None,
Expand Down
Loading