Skip to content

Conversation

@borchero
Copy link
Member

Motivation

Due to the lack of support for adding metadata to Parquet files written by polars prior to polars 1.30, we're currently writing required metadata in a rather hacky way when serializing FailureInfo. With polars 1.30 introducing support for parquet metadata (pola-rs/polars#21806), we can streamline our logic.

Changes

  • Use Parquet metadata to serialize rule columns of failure info
  • Bump polars version requirement to >=1.30 (does this warrant a minor release?)

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1a8f64e) to head (1cbc30f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1893      1899    +6     
=========================================
+ Hits          1893      1899    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@delsner delsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work on contributing this upstream! 🎉

@borchero borchero requested a review from delsner June 12, 2025 08:22
@borchero borchero merged commit f891a59 into main Jun 12, 2025
18 checks passed
@borchero borchero deleted the parquet-metadta branch June 12, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants