feat: Allow semantic comparison of collections #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 2175 2207 +32
=========================================
+ Hits 2175 2207 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
borchero
reviewed
Jun 17, 2025
Member
borchero
left a comment
borchero
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments on implementational details :)
borchero
approved these changes
Jun 18, 2025
Co-authored-by: Oliver Borchert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Same as #55 but for
Collections instead ofSchemas. Preparation for serialization ofCollectiondefinitions.Changes
Collection.matches, which semantically compares the present collection with another one and returns a boolean indicating whether the two Collections are equivalent,.