feat: Introduce functionality to read and write typed parquets #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 2216 2255 +39
=========================================
+ Hits 2216 2255 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
AndreasAlbertQC
left a comment
AndreasAlbertQC
left a comment
There was a problem hiding this comment.
Super nice and clear, thanks @borchero !
Member
Author
|
Sorry, I didn't get to work on this again but I still meant to add proper support for partitioned datasets which also introduce some additional challenges at read-time 👀 I'll mark this as draft for now |
AndreasAlbertQC
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #57, we added support for serializing schemas to JSON. This PR now adds utility functions to serialize the schema as parquet metadata and leverage that schema when reading files.
Changes
{read,write,scan,sink}_parquetmethods to theSchemaclass