-
Notifications
You must be signed in to change notification settings - Fork 3
add ty #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 92.27% 92.39% +0.11%
==========================================
Files 18 18
Lines 2058 2051 -7
==========================================
- Hits 1899 1895 -4
+ Misses 159 156 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| [tool.ty.terminal] | ||
| error-on-warning = true | ||
| [tool.ty.rules] | ||
| invalid-method-override = "ignore" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this?
|
Hi @copilot - please explain why the changes introduced with this PR revolving around the caching of |
|
@pavelzw @ivergara It seems to me that the remaining ty complaints are due to it not fully understanding how the methods Does one of you have a better idea than adding 4 Unfortunately instance method caching is quite messy. |
| value_target = self.get_target_value(engine) | ||
| # ty can't figure out that this is a method and that self is passed | ||
| # as the first argument. | ||
| value_factual = self.get_factual_value(engine=engine) # type: ignore[missing-argument] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this to be quite dissatisfying :(
|
Hi @pavelzw - could you ptal at the changes I've made? |
|
@pavelzw kind bump :) |
No description provided.