Skip to content

Conversation

@ypriverol
Copy link
Collaborator

@rita-gama @DiogoCSTF @leandro-sobral:

Here is the first PR to clean up the project, making it easier for users with no deep-learning background to use it. I think that because it is a big PR, it's better to test before accepting it, rather than pulling my fork and testing it locally. As we discussed offline, we removed all the GenerativePRoteomics towards a cleaner version of the package GainPro

ypriverol and others added 23 commits December 14, 2025 19:45
First update of GainPro
Co-authored-by: Copilot <[email protected]>
More refinements related with folder structure
Improve documentation
@ypriverol ypriverol requested a review from rita-gama December 15, 2025 14:59
@ypriverol ypriverol added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@DiogoCSTF
Copy link
Collaborator

I have tested and I have only a few points to address:

  1. The download function gives the idea that it can download and use any pre-trained model from Hugging Face, and even though it can download any model, the usage part is not so true because the code in it is specific for the GAIN_DANN model. This is something the have into account for that function.

  2. When I was running the GAIN-DANN model, I got an error message regarding line 179 in the gainpro.py file.
    I believe what is happening is that you are calling the Data module from our Gain model instead of the DataDANN module, which is specific to the GAIN-DANN model. I believe the same might be happening in lines 185 and 256.

Apart from these, everything seems to be fine

@ypriverol
Copy link
Collaborator Author

ypriverol commented Jan 5, 2026

@DiogoCSTF Thanks for your review I have tackle you comments.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 65 out of 81 changed files in this pull request and generated 25 comments.

Comments suppressed due to low confidence (1)

gainpro/model.py:57

  • The method parameter should be self instead of cls. This is an instance method, not a class method, so using cls is misleading and incorrect.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 65 out of 81 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants