-
Notifications
You must be signed in to change notification settings - Fork 2
Major PR refactoring the code and making it easily to read / reuse for processing #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
First update of GainPro
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
More refinements related with folder structure
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Improve documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
I have tested and I have only a few points to address:
Apart from these, everything seems to be fine |
|
@DiogoCSTF Thanks for your review I have tackle you comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 65 out of 81 changed files in this pull request and generated 25 comments.
Comments suppressed due to low confidence (1)
gainpro/model.py:57
- The method parameter should be
selfinstead ofcls. This is an instance method, not a class method, so usingclsis misleading and incorrect.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Minor changes responding to Diogo's comments
minor comments from Copilot adressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 65 out of 81 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
minor changes
@rita-gama @DiogoCSTF @leandro-sobral:
Here is the first PR to clean up the project, making it easier for users with no deep-learning background to use it. I think that because it is a big PR, it's better to test before accepting it, rather than pulling my fork and testing it locally. As we discussed offline, we removed all the GenerativePRoteomics towards a cleaner version of the package GainPro