-
Notifications
You must be signed in to change notification settings - Fork 69
Add support for batched fairchem inference for many parallel jobs #3121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zulissimeta
wants to merge
20
commits into
Quantum-Accelerators:main
Choose a base branch
from
zulissimeta:batched_fairchem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add support for batched fairchem inference for many parallel jobs #3121
zulissimeta
wants to merge
20
commits into
Quantum-Accelerators:main
from
zulissimeta:batched_fairchem
+1,091
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3121 +/- ##
==========================================
- Coverage 97.69% 96.28% -1.42%
==========================================
Files 97 97
Lines 4172 4248 +76
==========================================
+ Hits 4076 4090 +14
- Misses 96 158 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds support for FAIRChem batched inference via the
InferenceBatcherfromfairchem.core.calculate. This enables efficient GPU batching when running the same calculation (e.g., relaxations, static calculations) on many structures concurrently.Key additions:
New
map_partition_fairchembatchfunction insrc/quacc/wflow_tools/job_patterns.py:@jobthat processes a single partition (flat list) of atoms using FAIRChem batched inferenceNew
map_partitioned_lists_fairchembatchfunction insrc/quacc/wflow_tools/job_patterns.py:map_partition_fairchembatchjobsmap_partitioned_lists/map_partitionpatternNew
get_inference_batcherfunction insrc/quacc/recipes/mlp/_base.py:InferenceBatcherinstances keyed by model configurationshutdown_inference_batchers()for cleanupUpdated
pick_calculatorinsrc/quacc/recipes/mlp/_base.py:predict_unitkwarg to use batched inferencepredict_unitis provided for thread-safety during concurrent executionExample usage:
Tests:
Requirements
main).